Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags are not being applied to instances in aws_spot_instance_request resources #13229

Closed
ghost opened this issue May 8, 2020 · 5 comments
Closed
Labels
service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@ghost
Copy link

ghost commented May 8, 2020

This issue was originally opened by @machadovilaca as hashicorp/terraform#24880. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version

Terraform v0.12.24

Terraform Configuration Files

resource "aws_spot_instance_request" "spot_node" {
  ami = "ami-0e312952b4cc28a7f"
  instance_type = "t3.small"
  
  wait_for_fulfillment = true

  tags = {
    Name   = "Spot-node-1"
  }
}

Expected Behavior

Spot instance with name "Spot-node-1" created.

Actual Behavior

Spot instance with no name created.

Steps to Reproduce

  1. terraform init
  2. terraform apply

References

@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label May 8, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 8, 2020
@ewbankkit
Copy link
Contributor

@machadovilaca Thanks for raising this.
The issue has been noted in #32 (and others) and a solution discussed in #9061 (comment).
Could you please close this issue and upvote the linked issues?

@DrFaust92
Copy link
Collaborator

@ewbankkit , a thought about this specific case. the EC2 Instance ID is known, and while there spot instance request API doesn't allow for tagging the instance directly (at the moment). another call to tag the instance can be added

@ewbankkit
Copy link
Contributor

@DrFaust92 Yes, we could but I think it would complicate the aws_spot_instance_request resource.
It seems that thinking is converging on something based #8457 as a solution to these kind of problems.

@ewbankkit
Copy link
Contributor

Closing as duplicate of #32.

@ghost
Copy link
Author

ghost commented Jul 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 4, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

3 participants