Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_eks_node_group is missing way to configure taints on nodes #12780

Closed
lzecca78 opened this issue Apr 11, 2020 · 3 comments
Closed

aws_eks_node_group is missing way to configure taints on nodes #12780

lzecca78 opened this issue Apr 11, 2020 · 3 comments
Labels
service/eks Issues and PRs that pertain to the eks service.

Comments

@lzecca78
Copy link

I am trying to add taints to node_group, but is currently missing a parameter that allow that.
Is there a workaround for that or the only way is to change approach and discard the aws_eks_node_group resource making manually asg and so on?

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 11, 2020
@DrFaust92 DrFaust92 added the service/eks Issues and PRs that pertain to the eks service. label May 21, 2020
@aviau
Copy link
Contributor

aviau commented May 27, 2020

Is this even possible with the EKS API?

The CreateNodeGroup API is documented here:

The eks boostrap script supports setting taints, however:

EKS node groups are backed by AutoScaling Groups, which are available from the aws_eks_node_group attributes.

Autoscaling groups are backed by launch configurations, which contain User data scripts.

User data scripts created by EKS contain code that calls /etc/eks/bootstrap.sh.

As a workaroud until this is fully implemented in the CreateNodeGroup API, I think that it would be possible to find that launch template from the eks_node_group and manage it with terraform?

I don't want to go around breaking everything but I really need this feature.

Edit: Related AWS discussion: aws/containers-roadmap#864

@bflad
Copy link
Contributor

bflad commented Dec 1, 2020

Hi folks 👋 As mentioned in the excellent comment above, this is not directly supported in the EKS API, therefore it is not something we would implement in the Terraform AWS Provider aws_eks_node_group resource. To follow the upstream issue on this, please see aws/containers-roadmap#864. When that support is potentially implemented, we can revisit adding this functionality within the Terraform AWS Provider. 👍

@bflad bflad closed this as completed Dec 1, 2020
@ghost
Copy link

ghost commented Dec 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 31, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

No branches or pull requests

5 participants