Changing the SpotFleet capacity to 0 returns an error (bug in the AWS provider)

[shani-e]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

0.12.24

Affected Resource(s)

• aws_spot_fleet_request

Terraform Configuration Files

resource "aws_spot_fleet_request" "eks_spot_fleet" {
  iam_fleet_role                     = data.aws_iam_role.aws-ec2-spot-fleet-tagging-role.arn

  target_capacity                    = var.spotfleet_capacity
 
 replace_unhealthy_instances        = true
  excess_capacity_termination_policy = "Default"
  fleet_type                         = "maintain"
  allocation_strategy                = "diversified"
  valid_until                        = "2050-01-01T00:00:00Z"

  launch_specification {
    instance_type            = var.worker_instance_type
    ami                      = var.kuberenets_worker_image_id
    key_name                 = var.key_pair_name
    iam_instance_profile_arn = aws_iam_instance_profile.instance-profile.arn
    availability_zone        = data.aws_availability_zones.available.names[0]
    subnet_id                = aws_subnet.private-subnet_a.id
    vpc_security_group_ids   = [aws_security_group.worker-security-group.id]
    user_data                = base64encode(local.spotfleet-node-userdata)

    root_block_device {
      volume_size           = var.ebs_volume_size
      volume_type           = "gp2"
      delete_on_termination = true
    }

    tags = {
      "Name"                                      = "${var.cluster-name}-worker"
      "kubernetes.io/cluster/${var.cluster-name}" = "shared"
      "Cluster"                                   = var.cluster-name
      "SpotFleet"                                 = "true"
    }
  }
  }

Debug Output

https://gist.github.com/Shalgo/75e16468971ee065cdafcbf95ea2fbef

Expected Behavior

The capacity of the SpotFleet should be changed to 0 spots.

Actual Behavior

After changing the capacity to "0" in AWS provider 2.57.0 I got this error after applied:

Error: error updating spot request (sfr-5a212ca5-c970-4beb-895c-93281ccd527b): InvalidParameterCombinationException: No attributes specified.
status code: 400, request id: bc707986-d852-4e66-b190-ca640ce42dd0

In older version of AWS provider , The fleet's capacity can be changed to 0 without receiving an error, but in fact, the operation does not take effect at all.
The capacity remains as it was.

If I reduce the fleet capacity to a number greater than 0 it works.
But if I change the capacity to 0, it does not really change, and no error is received.
The capacity remains as it was.

Steps to Reproduce

1. Specify the AWS provider to 2.57.0
2. Create a configuration of maintain spot fleet with some capacity >0 (like my example)
3. terraform apply
4. Change the Capacity to "0"
5. 'terraform apply'

Important Factoids

none

References

• #0000

[DrFaust92]

addressed in #12759

[shani-e]

After rechecked, I see that in AWS provider versions lower than 257.0, The fleet's capacity can be changed to 0 without receiving an error, but in fact the operation does not take effect at all. The capacity will remain as it was.
If I reduce the fleet capacity to a number greater than 0 it works. But if I change the capacity to 0, it does not really change, and no error is received.

Please fix it so when the capacity changed to zero, it will work. Thanks.

[anGie44]

The bug fix has been merged and will release with the upcoming v3.1.0 of the Terraform AWS Provider.

[ghost]

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!