Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of publishing destination in a GuardDuty Detector resource #12753

Closed
khbvirus opened this issue Apr 9, 2020 · 3 comments
Closed
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.

Comments

@khbvirus
Copy link

khbvirus commented Apr 9, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

New or Affected Resource(s)

  • aws_guardduty_detector

Description

This request is related to a new feature released by AWS in November 2019 and it enables a GuardDuty detector to send the finding to an S3 bucket.

Today the GuardDuty detector resource supports only the following arguments:

enable - (Optional) Enable monitoring and feedback reporting. Setting to false is equivalent to "suspending" GuardDuty. Defaults to true.
finding_publishing_frequency - (Optional) Specifies the frequency of notifications sent for subsequent finding occurrences.

Support should be added for the creation of publishing destination.

The desination should have two properties:

  • destination ARN (should be S3 bucket).
  • KMS key ARN that will be used to encrypt the findings.

References

(https://docs.aws.amazon.com/guardduty/latest/APIReference/API_CreatePublishingDestination.html)

@khbvirus khbvirus added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 9, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2020
@ghost ghost added the service/guardduty Issues and PRs that pertain to the guardduty service. label Apr 9, 2020
@khbvirus
Copy link
Author

khbvirus commented Apr 9, 2020

@bflad I could give it a try, but I need some guidance on the way that his will need to be implemented in the provider?
Is it a new resource? or attributes of aws_guardduty_detector will do?

@khbvirus
Copy link
Author

A duplicate of #10920.
Closing the issue.

@ghost
Copy link

ghost commented May 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators May 10, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/guardduty Issues and PRs that pertain to the guardduty service.
Projects
None yet
Development

No branches or pull requests

2 participants