Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/api_gateway_method_settings: allow zero ttl #12651

Merged
merged 4 commits into from
Jul 31, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 3, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12638

Release note for CHANGELOG:

resource_api_gateway_method_settings:  allow zero ttl value
resource_api_gateway_method_settings:  plan time validation for `unauthorized_cache_control_header_strategy` and `logging_level`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAPIGatewayMethodSettings_'
--- PASS: TestAccAWSAPIGatewayMethodSettings_basic (62.97s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheTtlInSeconds (99.01s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CachingEnabled (99.15s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_DataTraceEnabled (98.18s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_LoggingLevel (98.84s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_MetricsEnabled (99.42s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_Multiple (105.20s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_RequireAuthorizationForCacheControl (97.55s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit (99.58s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit (97.06s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_UnauthorizedCacheControlHeaderStrategy (99.45s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheDataEncrypted (104.38s)

add plan time validations to `logging level` and `unauthorized_cache_control_header_strategy`
@DrFaust92 DrFaust92 requested a review from a team April 3, 2020 09:03
@ghost ghost added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/apigateway Issues and PRs that pertain to the apigateway service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 3, 2020
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label May 22, 2020
@DrFaust92 DrFaust92 removed the needs-triage Waiting for first response or review from a maintainer. label Jul 24, 2020
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Jul 24, 2020
@ghost ghost added size/S Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Jul 24, 2020
@ewbankkit ewbankkit requested review from ewbankkit and removed request for a team July 25, 2020 21:25
@ewbankkit
Copy link
Contributor

LGTM.
Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayMethodSettings_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayMethodSettings_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayMethodSettings_basic
=== PAUSE TestAccAWSAPIGatewayMethodSettings_basic
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_CacheDataEncrypted
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_CacheDataEncrypted
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_CacheTtlInSeconds
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_CacheTtlInSeconds
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_CachingEnabled
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_CachingEnabled
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_DataTraceEnabled
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_DataTraceEnabled
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_LoggingLevel
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_LoggingLevel
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_MetricsEnabled
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_MetricsEnabled
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_Multiple
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_Multiple
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_RequireAuthorizationForCacheControl
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_RequireAuthorizationForCacheControl
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimitDisabledByDefault
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimitDisabledByDefault
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimitDisabledByDefault
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimitDisabledByDefault
=== RUN   TestAccAWSAPIGatewayMethodSettings_Settings_UnauthorizedCacheControlHeaderStrategy
=== PAUSE TestAccAWSAPIGatewayMethodSettings_Settings_UnauthorizedCacheControlHeaderStrategy
=== RUN   TestAccAWSAPIGatewayMethodSettings_disappears
=== PAUSE TestAccAWSAPIGatewayMethodSettings_disappears
=== CONT  TestAccAWSAPIGatewayMethodSettings_basic
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_RequireAuthorizationForCacheControl
=== CONT  TestAccAWSAPIGatewayMethodSettings_disappears
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_UnauthorizedCacheControlHeaderStrategy
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimitDisabledByDefault
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimitDisabledByDefault
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_CachingEnabled
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_Multiple
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_MetricsEnabled
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_LoggingLevel
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_DataTraceEnabled
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_CacheDataEncrypted
=== CONT  TestAccAWSAPIGatewayMethodSettings_Settings_CacheTtlInSeconds
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimitDisabledByDefault (36.92s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CachingEnabled (68.54s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimitDisabledByDefault (69.12s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheDataEncrypted (119.50s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheTtlInSeconds (130.54s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_disappears (162.07s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_basic (214.92s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_RequireAuthorizationForCacheControl (237.49s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit (281.97s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_Multiple (376.69s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_LoggingLevel (428.74s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_UnauthorizedCacheControlHeaderStrategy (460.51s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit (555.63s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_DataTraceEnabled (636.98s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_MetricsEnabled (726.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	726.157s

Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output of acceptance tests:

--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheDataEncrypted (374.87s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CacheTtlInSeconds (487.88s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_CachingEnabled (94.50s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_DataTraceEnabled (21.06s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_LoggingLevel (82.36s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_MetricsEnabled (224.97s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_Multiple (285.49s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_RequireAuthorizationForCacheControl (189.37s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimit (110.83s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingBurstLimitDisabledByDefault (750.06s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimit (454.36s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_ThrottlingRateLimitDisabledByDefault (52.13s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_Settings_UnauthorizedCacheControlHeaderStrategy (432.88s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_basic (153.46s)
--- PASS: TestAccAWSAPIGatewayMethodSettings_disappears (249.43s)

@anGie44 anGie44 merged commit d5d267b into hashicorp:master Jul 31, 2020
@anGie44 anGie44 added this to the v3.1.0 milestone Jul 31, 2020
anGie44 added a commit that referenced this pull request Jul 31, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 3.1.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Aug 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 31, 2020
@DrFaust92 DrFaust92 deleted the r/api_gateway_method_settings_ttl branch February 12, 2022 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/apigateway Issues and PRs that pertain to the apigateway service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_api_gateway_method_settings resource produced new value for was present but now absent
4 participants