Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource aws_network_interface - add ipv6 support #12260

Closed
ghost opened this issue Mar 4, 2020 · 3 comments · Fixed by #12281
Closed

resource aws_network_interface - add ipv6 support #12260

ghost opened this issue Mar 4, 2020 · 3 comments · Fixed by #12281
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ghost
Copy link

ghost commented Mar 4, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It seems you can't use ipv6_addresses or ipv6_address_count with aws_network_interface. Requesting addition of support here. Issue is: if you have an EC2 instance with multiple ENIs, you can't manage ipv6 with it. You can only seem to mange ipv6 with and ENI when it is the primary ENI via aws_instance using arguments ipv6_addresses or ipv6_address_count. I believe we should have the same two arguments available for aws_network_interface.

I believe vendor\github.com\aws\aws-sdk-go\service\ec2\api.go has the necessary methods to call from aws\resource_aws_network_interface.go.

This is regarding provider version 2.51.0.

New or Affected Resource(s)

  • aws_network_interface (affected)

Potential Terraform Configuration

Example - I'd like to be able to something like this and assign both ipv6 and private ipv4 addresses to an ENI. Today, ipv6_addresses is not a valid argument for this resource (nor is ipv6_address_count).

resource "aws_network_interface" "fw1_eni" {
  description       = "interface 1 for firewall 1"
  subnet_id         = var.subnet_ids[0]
  ipv6_addresses = [var.ips_v6[0]]
  private_ips       = [var.ips_v4[0]]
  security_groups   = [aws_security_group.fw_sg_1.id]
  source_dest_check = false
}

References

@ghost ghost added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Mar 4, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 4, 2020
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 26, 2020
@bflad bflad added this to the v3.12.0 milestone Oct 16, 2020
@bflad
Copy link
Contributor

bflad commented Oct 16, 2020

Support for new ipv6_addresses and ipv6_address_count arguments in the aws_network_interface resource has been merged and will release with version 3.12.0 of the Terraform AWS Provider, next week. Thanks to @DrFaust92 for the implementation. 👍

@ghost
Copy link

ghost commented Oct 22, 2020

This has been released in version 3.12.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants