Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ssm_parameter: Adding support for Intelligent-Tiering #11967

Merged

Conversation

slapula
Copy link
Contributor

@slapula slapula commented Feb 8, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11800

Release note for CHANGELOG:

r/aws_ssm_parameter: Adding support for Intelligent-Tiering

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSSMParameter_Tier'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSSMParameter_Tier -timeout 120m
=== RUN   TestAccAWSSSMParameter_Tier
=== PAUSE TestAccAWSSSMParameter_Tier
=== CONT  TestAccAWSSSMParameter_Tier
--- PASS: TestAccAWSSSMParameter_Tier (49.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	49.969s

@slapula slapula requested a review from a team February 8, 2020 03:38
@ghost ghost added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ssm Issues and PRs that pertain to the ssm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 8, 2020
@debragail
Copy link

@anGie44 is this merged?

Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@anGie44 anGie44 force-pushed the r-aws-ssm-parameter-intelligent-tiering branch from 14ea70d to 7202bde Compare March 16, 2021 05:42
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/XS Managed by automation to categorize the size of a PR. labels Mar 16, 2021
@anGie44 anGie44 force-pushed the r-aws-ssm-parameter-intelligent-tiering branch from 6ca47a2 to 212cc7f Compare March 16, 2021 06:42
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 16, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @slapula @debragail , apologies for the delay here! Overall looks great, I've added the changelog file now required for PRs in addition to more test coverage, cleaned up some legacy test code since we're in the neighborhood, and updated the ValidateFuncs with AWS SDK enumerations where applicable.

Thanks again @slapula! 🚀

Output of acceptance tests:

--- PASS: TestAccAWSSSMParameter_disappears (91.58s)
--- PASS: TestAccAWSSSMParameter_basic (152.89s)
--- PASS: TestAccAWSSSMParameter_secure (153.14s)
--- PASS: TestAccAWSSSMParameter_fullPath (153.27s)
--- PASS: TestAccAWSSSMParameter_secure_with_key (178.41s)
--- PASS: TestAccAWSSSMParameter_updateDescription (197.31s)
--- PASS: TestAccAWSSSMParameter_DataType_AwsEc2Image (205.97s)
--- PASS: TestAccAWSSSMParameter_overwrite (205.97s)
--- PASS: TestAccAWSSSMParameter_changeNameForcesNew (213.88s)
--- PASS: TestAccAWSSSMParameter_updateType (214.45s)
--- PASS: TestAccAWSSSMParameter_secure_keyUpdate (238.59s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToStandard (248.92s)
--- PASS: TestAccAWSSSMParameter_Tier (250.13s)
--- PASS: TestAccAWSSSMParameter_tags (250.66s)
--- PASS: TestAccAWSSSMParameter_Tier_IntelligentTieringToAdvanced (252.78s)

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 16, 2021
@anGie44 anGie44 added this to the v3.33.0 milestone Mar 16, 2021
@anGie44 anGie44 self-assigned this Mar 16, 2021
@anGie44 anGie44 merged commit 0aa0be9 into hashicorp:main Mar 17, 2021
@ghost
Copy link

ghost commented Mar 18, 2021

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 16, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ssm Issues and PRs that pertain to the ssm service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Intelligent-Tiering tier for aws_ssm_parameter
3 participants