Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent change proposal on ecs service capacity provider #11395

Closed
ghost opened this issue Dec 21, 2019 · 3 comments
Closed

Consistent change proposal on ecs service capacity provider #11395

ghost opened this issue Dec 21, 2019 · 3 comments
Labels
service/ecs Issues and PRs that pertain to the ecs service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@ghost
Copy link

ghost commented Dec 21, 2019

This issue was originally opened by @vladimirtiukhtin as hashicorp/terraform#23740. It was migrated here as a result of the provider split. The original body of the issue is below.


Terraform Version

Terraform v0.12.13
+ provider.aws v2.43.0
+ provider.random v2.2.1

Expected Behavior

When cluster's default capacity provider is used, no changes must be proposed to a service with no capacity provider defined.

Actual Behavior

Change is proposed

Steps to Reproduce

Create a cluster with default capacity provider

resource "aws_ecs_cluster" "cluster" {
  name = "test"
  capacity_providers = [
    "FARGATE",
    "FARGATE_SPOT"
  ]

  default_capacity_provider_strategy {
    capacity_provider = "FARGATE_SPOT"
    weight                   = 100
  }
}

Create a service not specifying capacity provider which forces it to use cluster's default

resource "aws_ecs_service" "service" {
  name                              = "test"
  cluster                           = "test"
  task_definition                   = aws_ecs_task_definition.task.arn
  desired_count                     = 1

  network_configuration {
    security_groups  = var.security_group_id
    subnets          = var.subnets
    assign_public_ip = false
  }
}

Apply. Now plan. A change to capacity provider will be proposed

@ghost ghost added the service/ecs Issues and PRs that pertain to the ecs service. label Dec 21, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 21, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Apr 9, 2020
@bflad bflad self-assigned this Apr 9, 2020
@louis-ellevation
Copy link

I am currently having trouble due to this issue. Combined with this issue it seems I can't have an ECS service use the default capacity provider without said service incurring downtime every time the terraform config is applied.

@alex-bes
Copy link

alex-bes commented Jul 9, 2020

I have managed to work around this issue as described in #11351 (comment)

Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Nov 17, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/ecs Issues and PRs that pertain to the ecs service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

3 participants