Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Firewall Manager management of Amazon VPC security groups #10471

Closed
ewbankkit opened this issue Oct 11, 2019 · 4 comments
Closed

AWS Firewall Manager management of Amazon VPC security groups #10471

ewbankkit opened this issue Oct 11, 2019 · 4 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service.

Comments

@ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS Firewall Manager now supports management of Amazon VPC security groups.

New or Affected Resource(s)

References

Announcement.
Blog post.

Requires AWS SDK v1.25.10, #10378.

Related:
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 11, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 11, 2019
@bflad bflad added new-resource Introduces a new resource. service/fms Issues and PRs that pertain to the fms service. enhancement Requests to existing resources that expand the functionality or scope. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. new-resource Introduces a new resource. labels Oct 11, 2019
@bflad
Copy link
Contributor

bflad commented Oct 11, 2019

For folks finding this issue, #4058 represents the feature request to add the new resource (with open PR (#9594). This issue represents enhancing that resource to include VPC security group management if the initial implementation does not include it.

@robh007
Copy link
Contributor

robh007 commented Oct 11, 2019

I can look to enhance my original PR @bflad.

@rsclarke-vgw rsclarke-vgw mentioned this issue Mar 16, 2020
Closed
@bill-rich
Copy link
Contributor

Added in #9594

@ghost
Copy link

ghost commented Feb 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/fms Issues and PRs that pertain to the fms service.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bflad @ewbankkit @bill-rich @robh007