Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag support in vpc_endpoint datasource #10465

Closed
kimor79 opened this issue Oct 10, 2019 · 4 comments · Fixed by #10503
Closed

tag support in vpc_endpoint datasource #10465

kimor79 opened this issue Oct 10, 2019 · 4 comments · Fixed by #10503
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@kimor79
Copy link

kimor79 commented Oct 10, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The current vpc_endpoint datasource only accepts an id, service name, state, or VPC id. If there are multiple endpoints for the same service (ie with different policies), this resource can't be used to select the desired one. Nor can it work properly when there are multiple endpoints for the same service: multiple VPC Endpoints matched; use additional constraints to reduce matches to a single VPC Endpoint

It would be nice if we could pass tags to filter on to identify which endpoint we want.

New or Affected Resource(s)

  • aws_vpc_endpoint datasource

Potential Terraform Configuration

data "aws_vpc_endpoint" "bar" {
  service_name = "com.amazonaws.${data.aws_region.current.name}.execute-api"
  tags {
    Name = "bar"
  }
}

data "aws_vpc_endpoint" "foo" {
  service_name = "com.amazonaws.${data.aws_region.current.name}.execute-api"
  tags {
    Name = "foo"
  }
}

References

@kimor79 kimor79 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 10, 2019
@ghost ghost added the service/ec2 Issues and PRs that pertain to the ec2 service. label Oct 10, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Oct 10, 2019
@ewbankkit
Copy link
Contributor

When the initial support for VPC Endpoint tagging was implemented I don't think the DescribeVpcEndpoints API method supported tag filters.
It looks like tag filters are now supported.
I can implement.

@hashibot hashibot removed the needs-triage Waiting for first response or review from a maintainer. label Oct 11, 2019
@bflad bflad added this to the v2.35.0 milestone Nov 2, 2019
@bflad
Copy link
Contributor

bflad commented Nov 2, 2019

Support for filtering by filter and tags arguments has been merged and will release with version 2.35.0 of the Terraform AWS Provider, Thursday next week. Thanks to @ewbankkit for the implementation. 👍

@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants