From b1867c49d488a7e911256f6061a590746ff115fe Mon Sep 17 00:00:00 2001 From: Brian Flad Date: Mon, 12 Oct 2020 13:21:04 -0400 Subject: [PATCH] tests/resource/aws_db_proxy_default_target_group: Check disappearance with DB Proxy removal since default Target Group cannot be removed (#15546) Previously: ``` === CONT TestAccAWSDBProxyDefaultTargetGroup_disappears TestAccAWSDBProxyDefaultTargetGroup_disappears: resource_aws_db_proxy_default_target_group_test.go:221: Step 1/1 error: Expected a non-empty plan, but got an empty plan! --- FAIL: TestAccAWSDBProxyDefaultTargetGroup_disappears (597.58s) ``` Output from acceptance testing: ``` --- PASS: TestAccAWSDBProxyDefaultTargetGroup_disappears (682.08s) ``` --- aws/resource_aws_db_proxy_default_target_group_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/aws/resource_aws_db_proxy_default_target_group_test.go b/aws/resource_aws_db_proxy_default_target_group_test.go index 6b19000ad8e..5add58a8f5f 100644 --- a/aws/resource_aws_db_proxy_default_target_group_test.go +++ b/aws/resource_aws_db_proxy_default_target_group_test.go @@ -216,6 +216,7 @@ func TestAccAWSDBProxyDefaultTargetGroup_SessionPinningFilters(t *testing.T) { func TestAccAWSDBProxyDefaultTargetGroup_disappears(t *testing.T) { var v rds.DBProxy + dbProxyResourceName := "aws_db_proxy.test" resourceName := "aws_db_proxy_default_target_group.test" rName := acctest.RandomWithPrefix("tf-acc-test") resource.ParallelTest(t, resource.TestCase{ @@ -227,7 +228,9 @@ func TestAccAWSDBProxyDefaultTargetGroup_disappears(t *testing.T) { Config: testAccAWSDBProxyDefaultTargetGroupConfig_Basic(rName), Check: resource.ComposeTestCheckFunc( testAccCheckAWSDBProxyExists(resourceName, &v), - testAccCheckResourceDisappears(testAccProvider, resourceAwsDbProxyDefaultTargetGroup(), resourceName), + // DB Proxy default Target Group implicitly exists so it cannot be removed. + // Verify disappearance handling for DB Proxy removal instead. + testAccCheckResourceDisappears(testAccProvider, resourceAwsDbProxy(), dbProxyResourceName), ), ExpectNonEmptyPlan: true, },