From 91d75b32995a8b47ac491659f760be701d78e3ac Mon Sep 17 00:00:00 2001 From: David Wells Date: Thu, 6 Feb 2020 01:43:51 +0000 Subject: [PATCH] resource/aws_default_security_group: Ensure description attribute is written into Terraform state (#11650) Output from acceptance testing: ``` --- PASS: TestAccAWSDefaultSecurityGroup_basic (9.33s) --- PASS: TestAccAWSDefaultSecurityGroup_classic (12.37s) ``` --- aws/resource_aws_default_security_group.go | 7 +++++-- aws/resource_aws_default_security_group_test.go | 2 ++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/aws/resource_aws_default_security_group.go b/aws/resource_aws_default_security_group.go index 3da1cf4f19b..b9e07b97920 100644 --- a/aws/resource_aws_default_security_group.go +++ b/aws/resource_aws_default_security_group.go @@ -15,8 +15,11 @@ func resourceAwsDefaultSecurityGroup() *schema.Resource { dsg.Create = resourceAwsDefaultSecurityGroupCreate dsg.Delete = resourceAwsDefaultSecurityGroupDelete - // Descriptions cannot be updated - delete(dsg.Schema, "description") + // description is a computed value for Default Security Groups and cannot be changed + dsg.Schema["description"] = &schema.Schema{ + Type: schema.TypeString, + Computed: true, + } // name is a computed value for Default Security Groups and cannot be changed delete(dsg.Schema, "name_prefix") diff --git a/aws/resource_aws_default_security_group_test.go b/aws/resource_aws_default_security_group_test.go index 0809a1bcef8..4cf3e0392f0 100644 --- a/aws/resource_aws_default_security_group_test.go +++ b/aws/resource_aws_default_security_group_test.go @@ -27,6 +27,8 @@ func TestAccAWSDefaultSecurityGroup_basic(t *testing.T) { testAccCheckAWSDefaultSecurityGroupAttributes(&group), resource.TestCheckResourceAttr( "aws_default_security_group.web", "name", "default"), + resource.TestCheckResourceAttr( + "aws_default_security_group.web", "description", "default VPC security group"), resource.TestCheckResourceAttr( "aws_default_security_group.web", "ingress.3629188364.protocol", "tcp"), resource.TestCheckResourceAttr(