Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when removing user attributes #77

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Fix bug when removing user attributes #77

merged 1 commit into from
Jan 21, 2021

Conversation

koikonom
Copy link
Contributor

Fixes #75

Clear attributes by setting them to $null instead of ""
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koikonom koikonom merged commit 7e3a96e into main Jan 21, 2021
@koikonom koikonom deleted the user_null_fields branch January 21, 2021 21:58
@ghost
Copy link

ghost commented Feb 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

given_name and surname detected as null in v0.4.1
2 participants