Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export SID for security principals #76

Merged
merged 3 commits into from
Jan 21, 2021
Merged

Export SID for security principals #76

merged 3 commits into from
Jan 21, 2021

Conversation

koikonom
Copy link
Contributor 

Export SID for Security Principals objects

Add a computed field that holds an object's SID.
This applies to user, group, and computer resources and datasources.

Closes #60.

Kyriakos Oikonomakos added 2 commits January 20, 2021 16:45
Export SID for Security Principals objects
3cc4b48 
Add a computed field that holds an object's SID.
This applies to user, group, and computer resources and datasources.

Closes #60.
Fix field name in user datasource
a5197ec
@ghost ghost added size/S labels Jan 20, 2021
manicminer
manicminer approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few minor comments. Sorry for terseness, am reviewing on my phone and it keeps autocorrecting me. Otherwise LGTM!

ad/data_source_ad_user.go Outdated Show resolved Hide resolved
ad/data_source_ad_group.go Outdated Show resolved Hide resolved
ad/resource_ad_group.go Outdated Show resolved Hide resolved
ad/resource_ad_user.go Outdated Show resolved Hide resolved
@koikonom koikonom merged commit e8f0f66 into main Jan 21, 2021
@koikonom koikonom deleted the sid_field branch January 21, 2021 10:04
@ghost
Copy link

ghost commented Feb 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

@tombuildsstuff tombuildsstuff Awaiting requested review from tombuildsstuff

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koikonom @manicminer