all: Bump minimum Go version to 1.19

[bflad]

Reference: #265

Bumped via:

go mod edit -go=1.19
go mod tidy
go fix ./...

[bflad]

It looks like the Go update is awkwardly causing Go comment differences in the Protocol Buffers files between local and CI compilation, which unfortunately are not easily reconcilable (e.g. the first one is a protoc generated comment):

--- a/tfprotov5/internal/tfplugin5/tfplugin5.pb.go
+++ b/tfprotov5/internal/tfplugin5/tfplugin5.pb.go
@@ -1061,6 +1061,7 @@ type AttributePath_Step struct {
 	unknownFields protoimpl.UnknownFields
 
 	// Types that are assignable to Selector:
+	//
 	//	*AttributePath_Step_AttributeName
 	//	*AttributePath_Step_ElementKeyString
 	//	*AttributePath_Step_ElementKeyInt
@@ -2486,9 +2487,9 @@ type PlanResourceChange_Response struct {
 	// specific details of the legacy SDK type system, and are not a general
 	// mechanism to avoid proper type handling in providers.
 	//
-	//     ====              DO NOT USE THIS              ====
-	//     ==== THIS MUST BE LEFT UNSET IN ALL OTHER SDKS ====
-	//     ====              DO NOT USE THIS              ====
+	//	====              DO NOT USE THIS              ====
+	//	==== THIS MUST BE LEFT UNSET IN ALL OTHER SDKS ====
+	//	====              DO NOT USE THIS              ====
 	LegacyTypeSystem bool `protobuf:"varint,5,opt,name=legacy_type_system,json=legacyTypeSystem,proto3" json:"legacy_type_system,omitempty"`
 }

Running locally, it will remove the extra line of comment, for example. The other changes we could potentially update the definition files.

The upstream setup-protoc action has been unable to use newer protoc versions since the protoc versioning scheme was switched, although maybe that support will land soon with arduino/setup-protoc#58.

[bflad]

I was able to sort out my local generation issue. I had run brew install protoc-gen-go back on Go 1.18 and since brew builds from source, so it was using that older Go version comment formatting. brew reinstall protoc-gen-go did the trick.

This is ready for review and will handle #268 afterwards (Homebrew already has the new version).

[bendbennett]

LGTM 👍

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.