-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Bump minimum Go version to 1.19 #266
Conversation
Reference: #265
It looks like the Go update is awkwardly causing Go comment differences in the Protocol Buffers files between local and CI compilation, which unfortunately are not easily reconcilable (e.g. the first one is a --- a/tfprotov5/internal/tfplugin5/tfplugin5.pb.go
+++ b/tfprotov5/internal/tfplugin5/tfplugin5.pb.go
@@ -1061,6 +1061,7 @@ type AttributePath_Step struct {
unknownFields protoimpl.UnknownFields
// Types that are assignable to Selector:
+ //
// *AttributePath_Step_AttributeName
// *AttributePath_Step_ElementKeyString
// *AttributePath_Step_ElementKeyInt
@@ -2486,9 +2487,9 @@ type PlanResourceChange_Response struct {
// specific details of the legacy SDK type system, and are not a general
// mechanism to avoid proper type handling in providers.
//
- // ==== DO NOT USE THIS ====
- // ==== THIS MUST BE LEFT UNSET IN ALL OTHER SDKS ====
- // ==== DO NOT USE THIS ====
+ // ==== DO NOT USE THIS ====
+ // ==== THIS MUST BE LEFT UNSET IN ALL OTHER SDKS ====
+ // ==== DO NOT USE THIS ====
LegacyTypeSystem bool `protobuf:"varint,5,opt,name=legacy_type_system,json=legacyTypeSystem,proto3" json:"legacy_type_system,omitempty"`
} Running locally, it will remove the extra line of comment, for example. The other changes we could potentially update the definition files. The upstream setup-protoc action has been unable to use newer protoc versions since the protoc versioning scheme was switched, although maybe that support will land soon with arduino/setup-protoc#58. |
I was able to sort out my local generation issue. I had run This is ready for review and will handle #268 afterwards (Homebrew already has the new version). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Reference: #265
Bumped via: