-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ignoring undefined attributes during unmarshalling #213
Conversation
of opts which can be used to modify the unmarshalling behaviour, such as ignoring undefined attributes (#212)
84f9320
to
cff7cc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks really good -- just a few minor things to tidy up and I think we'll be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just two little bitty things to consider 🚀
Co-authored-by: Brian Flad <[email protected]>
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Closes: #212
An error is generated when unmarshalling JSON that contains fields that do not have a corresponding attribute.
This PR adds an additional function,
UnmarshalWithOpts
that allows supplying of options that modify unmarshalling behaviour. Specifically, ignoring of undefined attributes is configurable.