all: Add support for Manual Deferred Actions #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d `DeferredResponse` respectively to match protobuf definition
# Conflicts: # go.sum
austinvalle
reviewed
May 9, 2024
bflad
reviewed
May 10, 2024
There was a problem hiding this comment.
Drive-by minor comments since @austinvalle is already reviewing -- please let me know if you have any questions. 😄
Co-authored-by: Austin Valle <[email protected]>
bflad
reviewed
May 14, 2024
There was a problem hiding this comment.
Overall looks good to me, nice work. I'll let @austinvalle give the final 👍
Co-authored-by: Brian Flad <[email protected]>
austinvalle
reviewed
May 14, 2024
austinvalle
reviewed
May 14, 2024
austinvalle
approved these changes
May 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: hashicorp/terraform-plugin-go#403
This PR implements manual deferred action support for ReadResource, ReadDataSource, ImportResourceState, and PlanResourceChange RPCs. It adds new
resource.DeferredResponseanddatasource.DeferredResponsestructs so that providers can indicate a deferral to the Terraform client.Deferred actions is an experimental feature introduced in Terraform v1.9.0-alpha20240404 and is only available in experimental Terraform builds.
A follow up PR will implement automatic deferred action support for
PROVIDER_CONFIG_UNKNOWNduring the ConfigureProvider RPC.