Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stringvalidator: Add UTF-8 character count validators, clarify original length validators #87

Merged
merged 2 commits into from
Dec 20, 2022
Merged

stringvalidator: Add UTF-8 character count validators, clarify original length validators #87

merged 2 commits into from
Dec 20, 2022

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Dec 19, 2022

Closes #85

@bflad bflad added the enhancement New feature or request label Dec 19, 2022
@bflad bflad added this to the v0.9.0 milestone Dec 19, 2022
@bflad bflad requested a review from a team as a code owner December 19, 2022 19:16
@bflad bflad mentioned this pull request Dec 19, 2022
Closed
1 task
bendbennett
bendbennett approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad merged commit 692fbd3 into main Dec 20, 2022
@bflad bflad deleted the bflad/utf8-length-validators branch December 20, 2022 13:49
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bendbennett bendbennett bendbennett approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

stringvalidator: Support for multibyte strings
2 participants
@bflad @bendbennett