Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Add support for Int32 and Float32 Type Validators #222

Merged
merged 9 commits into from
Jul 9, 2024

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Jun 26, 2024

Relates: hashicorp/terraform-plugin-framework#1010
Relates: hashicorp/terraform-plugin-framework#1014

Add support for Int32 and Float32 Type Validators:

  • Adds int32validator and float32validator packages with type specific validators
  • Add ValueFloat32sAre and ValueInt32sAre validators to listvalidator, mapvalidator, and setvalidator packages

Will hold off on merging until terraform-plugin-framework v1.10.0 is released with int32 and float32 type support.

@SBGoods SBGoods marked this pull request as ready for review July 1, 2024 21:01
@SBGoods SBGoods requested a review from a team as a code owner July 1, 2024 21:01
@SBGoods SBGoods changed the title [DRAFT] all: Add support for Int32 and Float32 Type Validators all: Add support for Int32 and Float32 Type Validators Jul 1, 2024
@austinvalle austinvalle added this to the v0.13.0 milestone Jul 2, 2024
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, like you mentioned in the PR, can release once we get Framework v1.10 out 🚀

If you end up accepting the suggestions for updating the examples, can you also update the Int64 examples?

int32validator/any_example_test.go Outdated Show resolved Hide resolved
int32validator/all_example_test.go Outdated Show resolved Hide resolved
int32validator/any_with_all_warnings_example_test.go Outdated Show resolved Hide resolved
@austinvalle austinvalle added the enhancement New feature or request label Jul 2, 2024
@SBGoods SBGoods merged commit ba395d2 into main Jul 9, 2024
6 checks passed
@SBGoods SBGoods deleted the SBGoods/int32-float32-validators branch July 9, 2024 16:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants