Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add All, Any, and AnyWithAllWarnings validators to boolvalidator, providervalidator, resourcevalidator and datasourcevalidator packages #158

Merged
merged 9 commits into from
Aug 21, 2023

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Aug 18, 2023

Closes: #122

This PR adds All, Any, and AnyWithAllWarnings validators to the boolvalidator, providervalidator, resourcevalidator and datasourcevalidator packages to bring it in parity with the other validator packages. There are associated tests for all validators except for the ones in the boolvalidator package because of the complexities of test design for these particular tests. However, the logic used in these validators are the same across all corresponding validator packages, therefore the logic is already well tested.

@SBGoods SBGoods requested a review from a team as a code owner August 18, 2023 22:38
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bflad bflad added the enhancement New feature or request label Aug 21, 2023
@bflad bflad added this to the v0.12.0 milestone Aug 21, 2023
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor example fix, otherwise looks good to me 🚀

datasourcevalidator/any_with_all_warnings_example_test.go Outdated Show resolved Hide resolved
Co-authored-by: Brian Flad <[email protected]>
@SBGoods SBGoods merged commit cd82393 into main Aug 21, 2023
4 checks passed
@SBGoods SBGoods deleted the SBGoods/any-all-validators branch August 21, 2023 18:15
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing All, Any, and friends validators
3 participants