calc path in title next to anchorID #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Fixes hashicorp#285 Signed-off-by: Sebastian Hoß <[email protected]>
|
Rebased on latest main |
SBGoods
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Hi @sebhoss
Thank you for taking the time to look into to this! The code in the schemamd package is a bit convoluted but I think you're probably right that this likely caused by Go looping mechanics.
I've added an acceptance test and a changelog entry, but otherwise the PR looks good to me. Thanks again!
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I cannot quite explain it but this change fixes wrong path expressions in titles. I am guessing that Go's weird loop/pointer mechanics are at play here, but I failed to figure out where/why/how this is happening in this case.
Since the calculated anchorID is always correct, I've simply moved the calculation of the path title right next to it and everything immediately worked as expected.
As you can see in the testdata change, this bug has been around for a while and probably affects many providers in the ecosystem.
Fixes #285