Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Update LSP structs #604

Closed
radeksimko opened this issue Aug 3, 2021 · 1 comment · Fixed by #608
Closed

internal: Update LSP structs #604

radeksimko opened this issue Aug 3, 2021 · 1 comment · Fixed by #608
Labels
enhancement New feature or request

Comments

@radeksimko
Copy link
Member

Current Version

0.20.0

Use-cases

LSP structs we use to (de)serialize JSON requests & responses between client and server are outdated and the latest gopls version contains some type changes which would be better to bring in sooner than later, to avoid errors when clients pass something that doesn't match the type exactly.

Proposal

go generate ./internal/protocol/...
@radeksimko radeksimko added the enhancement New feature or request label Aug 3, 2021
@radeksimko radeksimko changed the title Update LSP structs internal: Update LSP structs Aug 3, 2021
@github-actions
Copy link

github-actions bot commented Sep 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant