Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/version: Introduce JSON output #184

Closed
radeksimko opened this issue Jun 25, 2020 · 3 comments · Fixed by #386
Closed

cmd/version: Introduce JSON output #184

radeksimko opened this issue Jun 25, 2020 · 3 comments · Fixed by #386
Assignees
Labels
enhancement New feature or request

Comments

@radeksimko
Copy link
Member

Current Version

0.3.2

Use-cases

The VSCode extension and potentially other IDEs/extensions might want to manage the installation/upgrade of the language server. This would be little easier if they could read JSON output instead of line-based one.

Attempted Solutions

https://github.com/hashicorp/vscode-terraform/blob/1c882b35bb52e834214fad186c167f8ecaf04804/src/languageServerInstaller.ts#L32-L33

Proposal

Introduce terraform-ls version -json which has similar output to the recently introduced terraform version -json: hashicorp/terraform#25252

@radeksimko
Copy link
Member Author

radeksimko commented Jun 25, 2020

@aeschright I'm aware we just keep updating without letting the user pin the LS to any version - so in the "happy path" this shouldn't cause problem with adoption once we upgrade most people to the version which has JSON output. But does the VSCode extension also check --version for custom installations?

@aeschright
Copy link
Contributor

No, if you set an explicit path to the binary we don't do any further checks.

@ghost
Copy link

ghost commented Feb 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants