Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Can not update sensitive variables if non sensitive variables don't have any change #161

Open
yqxiaxia opened this issue Mar 14, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@yqxiaxia
Copy link

yqxiaxia commented Mar 14, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

terraform-k8s & Kubernetes Version

Affected Resource(s)

Terraform Configuration Files

# Copy-paste your Terraform configuration from the operator here.
# To retrieve the configuration, use `kubectl -n $NAMESPACE describe configmap $WORKSPACE_NAME`

Debug Output

Expected Behavior

Always update sensitive variables before a Run. Applying a workspace with sensitive or nonsensitive variable change, the workspace update should always be triggered

Actual Behavior

Hi team, I applied workspace with sensitive variable change, but no nonsensitive variable changes. And then it would not trigger workspace update.

Check the code here: https://github.com/hashicorp/terraform-k8s/blob/main/workspacehelper/tfc_variable.go#L135
it shows if there is no nonsensitive variable change, will skip the sensitive variables change.

why should do this?

Steps to Reproduce

Important Factoids

References

  • #0000
@yqxiaxia yqxiaxia added the bug Something isn't working label Mar 14, 2023
@yqxiaxia
Copy link
Author

Hi here, any idea about this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant