Env Var handling and TF_LOG_PATH support #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
changed the title
Merged
kmoe
reviewed
Jul 20, 2020
paultyng
force-pushed
the
logging
branch
4 times, most recently
from
9e8f78c
to
2e5e74b
Compare
Also add missing -input=false for Destroy
|
@kmoe tests look green now. |
kmoe
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP to modify env var handling slightly and add support for TF_LOG_PATH to tfexec. Unsure if this fulfills the existing use case yet, but just putting this up for further discussion in the meantime.