Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow "all" as ignoreChanges lifecycle value #1848

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

x3cion
Copy link
Contributor

@x3cion x3cion commented Jun 7, 2022

ignoreChanges can be "all" ignoring all changes. This has to be reflected by the type (if that's true for all resources?).

Closes #1425

@x3cion x3cion changed the title Allow "all" as ignoreChanges lifecycle value fix: Allow "all" as ignoreChanges lifecycle value Jun 7, 2022
Copy link
Collaborator

@jsteinich jsteinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @x3cion

@ansgarm
Copy link
Member

ansgarm commented Jun 14, 2022

This will close #1425

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "all" for ignoreChanges in lifecycle
3 participants