Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add guidance around secrets and warn that those values might be inlined in the generated Terraform config #1801

Merged
merged 2 commits into from
May 13, 2022

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented May 12, 2022

No description provided.

…ght be inlined in the generated Terraform config
Copy link
Contributor

@laurapacilio laurapacilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so I don't block, but a few language nits :-) Thank you for adding this, it's very important!

website/docs/cdktf/concepts/variables-and-outputs.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/project-setup.mdx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants