Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): allow init command to run in a directory containing a README.md #1722

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Apr 14, 2022

When creating a new Git repository via Github one can easily add a README.md resulting in an non-empty new git repo in which cdktf init won't work then

Related to #1697

…E.md

When creating a new Git repository via Github one can easily add a README.md resulting in an non-empty new git repo in which cdktf init won't work then

Related to #1697
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉

@DanielMSchmidt DanielMSchmidt merged commit 50f14f5 into main Apr 14, 2022
@DanielMSchmidt DanielMSchmidt deleted the allow-readme-md-for-init branch April 14, 2022 15:08
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants