fix(cli): improve cli error handling #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ansgarm
commented
Apr 5, 2022
ansgarm
commented
- chore(deps): update yargs type defs
- fix(cli): be explicit about yargs not exiting the process on failure
- fix(cli): make stack positional argument optional
- fix(cli): exit the process on uncaught errors from yargs handlers
- fix(cli): throw Usage error instead of local process.exit()
- refactor(cli): Don't catch errors locally in command handlers as they are now caught properly on a global level in .fail()
Exiting the process has already implicitly been disabled by passing a callback to `.fail()`. Now this is more explicit.
previously this caused .fail() to be called with a message (but no error) which in turn caused debug information to be printed without cancelling the process itself. Another commit will fix this and stop everything if argument validation fails
and print validation messages and abort in that case as well
… are now caught properly on a global level in .fail()
ansgarm
changed the title
…ks things after changing positional arguments to optional
|
CI currently fails because somehow yargs tries to run the command when returning completions for it (see yargs/yargs#1965). I'm going to implement the workaround mentioned in the issue in a base command class. |
…ell completions are prepared
DanielMSchmidt
approved these changes
Apr 6, 2022
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.