Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcl2cdk: produces incorrect typescript with mix of quoted and unquoted values #2912

Open
sentry-io bot opened this issue Jun 1, 2023 · 3 comments
Open
Assignees
Labels
bug Something isn't working feature/convert priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. size/medium estimated < 1 week

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 1, 2023

Sentry Issue: CDKTF-REGISTRY-DOCS-1A0

SyntaxError: Unexpected token, expected "," (45:32)
  43 |       "destination": "s3",
  44 |       "lifecycle": {
> 45 |         "ignoreChanges": [tags_"logDeliveryEnabled"]
     |                                ^
  46 |       },
  47 |       "name": "terraform-k...
  File "/__t/node/18.16.0/x64/lib/node_modules/cdktf-registry-docs/node_modules/prettier/parser-babel.js", line 22, in p
    '{snip} eate-error.js"(l,h){"use strict";U();function p(d,x){let P=new SyntaxError(d+" ("+x.start.line+":"+x.start.column+")");return P.loc=x,P}h.ex {snip}
  File "/__t/node/18.16.0/x64/lib/node_modules/cdktf-registry-docs/node_modules/prettier/parser-babel.js", line 22, in d
    '{snip} U();var p=lr();function d(x){let{message:P,loc:m}=x;return p(P.replace(/ \(.*\)/,""),{start:{line:m?m.line:0,column:m?m.column+1:0}})}h.expo {snip}
  File "/__t/node/18.16.0/x64/lib/node_modules/cdktf-registry-docs/node_modules/prettier/parser-babel.js", line 29, in Object.parse
    '{snip} sult:k,error:F}=Yf(...v.map(w=>()=>od(l,x,w)));if(!k)throw ed(F);return m.originalText=x,td(k,m)}}var ld=$e("parse",he(["jsx","flow"])),Lo=$ {snip}
  File "/__t/node/18.16.0/x64/lib/node_modules/cdktf-registry-docs/node_modules/prettier/index.js", line 7515, in Object.parse
    ast: parser.parse(text, parsersForCustomParserApi, opts)
  File "/__t/node/18.16.0/x64/lib/node_modules/cdktf-registry-docs/node_modules/prettier/index.js", line 8829, in coreFormat
    } = parser.parse(originalText, opts);
...
(5 additional frame(s) were not displayed)
@sentry-io
Copy link
Author

sentry-io bot commented Jun 1, 2023

Sentry issue: CDKTF-REGISTRY-DOCS-108

@sentry-io
Copy link
Author

sentry-io bot commented Jun 1, 2023

Sentry issue: CDKTF-REGISTRY-DOCS-10B

@DanielMSchmidt DanielMSchmidt added bug Something isn't working needs-priority Issue has not yet been prioritized; this will prompt team review feature/convert size/medium estimated < 1 week labels Jun 1, 2023
@DanielMSchmidt DanielMSchmidt added this to the 0.17 (tentative) milestone Jun 1, 2023
@mutahhir
Copy link
Member

Source:

  lifecycle {
    ignore_changes = [
      tags["LogDeliveryEnabled"],
    ]
  }

Seems like we can't deal with this kind of syntax right now.

@xiehan xiehan added priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. and removed needs-priority Issue has not yet been prioritized; this will prompt team review labels Jul 20, 2023
@xiehan xiehan modified the milestones: 0.18, 0.20 (tentative) Aug 15, 2023
@xiehan xiehan removed this from the 0.20 (tentative) milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature/convert priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. size/medium estimated < 1 week
Projects
None yet
Development

No branches or pull requests

4 participants