Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdktf synth doesn't generate lambda assets archive when TerraformStack name contains whitespaces #1741

Closed
almmiko opened this issue Apr 24, 2022 · 1 comment · Fixed by #1750
Labels
bug Something isn't working priority/important-soon High priority, to be worked on as part of our current release or the following one. size/small estimated < 1 day ux/configuration

Comments

@almmiko
Copy link

almmiko commented Apr 24, 2022

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When TerraformStack name parameter contains whitespaces, the assets archive is not created.

Sample code:

new LambdaStack(app, 'lambda hello world', {
  path: "../lambda-hello-world/dist",
  handler: "index.handler",
  runtime: "nodejs14.x",
  stageName: "hello-world",
  version: "v0.0.2"
});

cdktf & Language Versions

"cdktf": "0.10.2"
"typescript": "^4.5.2"

Affected Resource(s)

TerraformAsset

Debug Output

No errors, process finishes without error logs

Expected Behavior

When using cdktf synth with lambda, the cdktf.out/stacks/{lambda-stack-name}/assets should have archived lambda source code.

Actual Behavior

cdktf.out/stacks/{lambda-stack-name}/assets folder doesn't contain archived lambda code

Steps to Reproduce

Clone the repo https://github.com/hashicorp/learn-cdktf-assets-stacks-lambda

Replace the lambda stack name lambda-hello-world with lambda hello world

run cdktf synth

check the output folder cdktf.out/stacks/{lambda-stack-name}/assets

Important Factoids

No

@almmiko almmiko added bug Something isn't working new Un-triaged issue labels Apr 24, 2022
@DanielMSchmidt DanielMSchmidt added priority/important-soon High priority, to be worked on as part of our current release or the following one. ux/configuration size/small estimated < 1 day and removed new Un-triaged issue labels Apr 26, 2022
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working priority/important-soon High priority, to be worked on as part of our current release or the following one. size/small estimated < 1 day ux/configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants