Upgrade Nodejs runtime from 12 to 16

[chenrui333]

This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)

cc @jpogran

[chenrui333]

It is also desired to make a new release after this PR update.

[jpogran]

Thanks for working on this! It was on my list of thing to do, but hadn't gotten to it yet. I admit I'm a bit nervous with the jump from 12 to 16, so we'll have to test this a bunch before we increment the v1 tag.

[chenrui333]

Thanks for working on this! It was on my list of thing to do, but hadn't gotten to it yet. I admit I'm a bit nervous with the jump from 12 to 16, so we'll have to test this a bunch before we increment the v1 tag.

I have to say, there is not much surprise that I have seen so far (ultimately it is just action runner update). :)

[chenrui333]

Also, it should be a major upgrade. With the runtime pointing to node16, it would only work Actions Runners v2.285.0 or later.

[jpogran]

Good point. I'll create separate milestones. I think the changes so far since last release are fine for 1.4, but a 2.0 for a major runner bump is warranted.

[chenrui333]

Sounds good, we can do two releases separately. 👍 😄

[ksatirli]

Hey @chenrui333 - this looks great (and tests well!)

@jpogran just released [1.4.0](https://github.com/hashicorp/setup-terraform/releases/tag/v1.4.0) - could you update the merging conflict?

[chenrui333]

totally, let me refresh my PR.

[chenrui333]

Any timeline to merge this PR?

[jpogran]

@chenrui333 I'll be reviewing the open PRs this week and determining which land in 2.0. Look towards that milestone for a delivery date this week

[magnetikonline]

Also, it should be a major upgrade. With the runtime pointing to node16, it would only work Actions Runners v2.285.0 or later.

100% this - follows the same pattern as the actions/* GitHub authored action set.

[jpogran]

Updating this in preparation for merge

[jpogran]

Thanks for the help @chenrui333 , this will go out in the 2.0 release, currently slated for 2022/04/15

[chenrui333]

Sounds good, thanks @jpogran!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.