importer-rest-api-specs - producing duplicate DirectAssignment mappings when create and read property payloads become optional

[stephybun]

To support generating simple resources that contain a resource ID segment of type scope we've had to introduce the changes in #3586.

One of the changes reverses the logic for when we set the Create and Read property payload and model names, no longer throwing an error if they are missing. As a result these properties are no longer required and have become optional. This change should also be reflected in the model for the operationPayloads, making the properties pointers:

pandora/tools/importer-rest-api-specs/components/schema/internal.go

Lines 7 to 22 in 19980c5

	type operationPayloads struct {
	createModelName string
	createPayload resourcemanager.ModelDetails
	createPropertiesModelName string
	createPropertiesPayload resourcemanager.ModelDetails
	readModelName string
	readPayload resourcemanager.ModelDetails
	readPropertiesModelName string
	readPropertiesPayload resourcemanager.ModelDetails
	updateModelName *string
	updatePayload *resourcemanager.ModelDetails
	updatePropertiesModelName *string
	updatePropertiesPayload *resourcemanager.ModelDetails
	}

Making this change results in duplicate DirectAssignment definitions in all the existing generated resources
e.g. the fieldMappings field in KubernetesClusterTrustedAccessRoleBinding-Resource-Mappings.json now looks like so:

"fieldMappings": [
		{
			"type": "DirectAssignment",
			"directAssignment": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"schemaFieldPath": "Roles",
				"sdkModelName": "TrustedAccessRoleBindingProperties",
				"sdkFieldPath": "Roles"
			}
		},
		{
			"type": "DirectAssignment",
			"directAssignment": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"schemaFieldPath": "Roles",
				"sdkModelName": "TrustedAccessRoleBindingProperties",
				"sdkFieldPath": "Roles"
			}
		},
		{
			"type": "DirectAssignment",
			"directAssignment": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"schemaFieldPath": "SourceResourceId",
				"sdkModelName": "TrustedAccessRoleBindingProperties",
				"sdkFieldPath": "SourceResourceId"
			}
		},
		{
			"type": "DirectAssignment",
			"directAssignment": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"schemaFieldPath": "SourceResourceId",
				"sdkModelName": "TrustedAccessRoleBindingProperties",
				"sdkFieldPath": "SourceResourceId"
			}
		},
		{
			"type": "ModelToModel",
			"modelToModel": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"sdkModelName": "TrustedAccessRoleBinding",
				"sdkFieldName": "Properties"
			}
		}
	],

Whereas it should actually remain like so

"fieldMappings": [
		{
			"type": "DirectAssignment",
			"directAssignment": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"schemaFieldPath": "Roles",
				"sdkModelName": "TrustedAccessRoleBindingProperties",
				"sdkFieldPath": "Roles"
			}
		},
		{
			"type": "DirectAssignment",
			"directAssignment": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"schemaFieldPath": "SourceResourceId",
				"sdkModelName": "TrustedAccessRoleBindingProperties",
				"sdkFieldPath": "SourceResourceId"
			}
		},
		{
			"type": "ModelToModel",
			"modelToModel": {
				"schemaModelName": "KubernetesClusterTrustedAccessRoleBindingResourceSchema",
				"sdkModelName": "TrustedAccessRoleBinding",
				"sdkFieldName": "Properties"
			}
		}
	],