Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecoveryServicesBackup @ 2023-06-01 - LRO's not marked as LRO's in the Swagger #2345

Open
mbfrahry opened this issue Apr 6, 2023 · 4 comments · May be fixed by Azure/azure-rest-api-specs#23524
Labels
data/swagger-issue An issue related to the Swagger/OpenAPI Definitions upstream/waiting-on-swagger-review This is fixed and currently waiting for review upstream in `Azure/azure-rest-api-specs`

Comments

@mbfrahry
Copy link
Member

mbfrahry commented Apr 6, 2023

There is a GetOperation function we are currently using in the Azure go sdk that I can't find Pandora.

I did see find it in the swagger for this service but I'm not sure if it's being mapped into pandora correctly

@tombuildsstuff
Copy link
Contributor

@mbfrahry what are we using this for? The OperationResult would be to query the LRO, which should be happening automagically, so we shouldn't need to call this, providing we're polling on the LRO?

@mbfrahry
Copy link
Member Author

It's for Inquiring when a new file share is added to an existing storage account. I haven't seen this before but here is the PR for context on what is going on hashicorp/terraform-provider-azurerm@dd37691

@tombuildsstuff
Copy link
Contributor

Right, in this case that operation is an LRO that should be marked as an LRO, then all of that logic can be removed in favour of an InquireThenPoll SDK call - I've opened Azure/azure-rest-api-specs#23524 to fix the Swagger, hopefully that's fixed quickly but if not we can add a Swagger workaround for that until the upstream issue is fixed.

@tombuildsstuff tombuildsstuff added data/swagger-issue An issue related to the Swagger/OpenAPI Definitions upstream/waiting-on-swagger-review This is fixed and currently waiting for review upstream in `Azure/azure-rest-api-specs` labels Jul 26, 2023
@tombuildsstuff tombuildsstuff changed the title Recovery Services - 2021-12-01 RecoveryServices @ 2021-12-01 Jul 27, 2023
@tombuildsstuff tombuildsstuff changed the title RecoveryServices @ 2021-12-01 RecoveryServices @ 2021-12-01 - LRO's not marked as LRO's in the Swagger Jul 27, 2023
@tombuildsstuff tombuildsstuff changed the title RecoveryServices @ 2021-12-01 - LRO's not marked as LRO's in the Swagger RecoveryServicesBackup @ 2023-06-01 - LRO's not marked as LRO's in the Swagger Nov 13, 2023
@tombuildsstuff
Copy link
Contributor

I've updated the upstream PR to target API version 2023-06-01, since there's a number of new API Versions since this opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data/swagger-issue An issue related to the Swagger/OpenAPI Definitions upstream/waiting-on-swagger-review This is fixed and currently waiting for review upstream in `Azure/azure-rest-api-specs`
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants