-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for dynamic directpath i/o #263
Conversation
docs-partials/builder/vsphere/common/HardwareConfig-not-required.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I left a few request regarding the documentation and tests. Can you please take a look at the requested changes and let me know if you have any questions.
docs-partials/builder/vsphere/common/HardwareConfig-not-required.mdx
Outdated
Show resolved
Hide resolved
@tenthirtyam could I get your help in testing the changes in this PR please. |
Hi @kshivakumar-nvidia there has been no updates on this PR since we last reviewed. I'm going to close it as it has become stale. If you find that you want to continue adding support for DirectPath please rebase your branch onto the latest main and update the PR and reopen. Thanks again for the contribution. |
Reopened and rebased. |
c8d87aa
to
c53c318
Compare
92e04d0
to
0c66959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adding support for vSphere Dynamic DirectPath I/O. Co-Authored-By: Ryan Johnson <[email protected]>
Description
As a part of the Assignable Hardware framework in vSphere 7, Dynamic DirectPath I/O is introduced. When configuring a virtual machine to use a PCIe device using Dynamic Direct I/O path, enables the Assignable Hardware intelligence for passthrough devices. No longer is the hardware address of the PCIe device directly mapped to the virtual machine configuration file (the .vmx file). Instead, the attributes, or capabilities, are exposed to the virtual machine.
Example
Tests
Reference
Closes #268