vmware-vmx: builder not attaching additional disks

[meangrape]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Overview of the Issue

When creating additional disks via

  disk_additional_size = [
    150000,
    150000
  ]

the additional disks are created in the output directory, but they are not attached to the created VM.

Packer version

Packer v1.8.5
vmware plugin 1.0.7

Simplified Packer Template

packer {
  required_plugins {
    vmware = {
      version = "= 1.0.7"
      source = "github.com/hashicorp/vmware"
    }
  }
}

source "vmware-vmx" "sentenai-fdb-300" {
  vm_name = "sentenai-fdb-300"
  headless = true
  source_path = "./output-sentenai-rhel-base/sentenai-rhel-base.vmx"
  ssh_username = "root"
  ssh_password = "rheluser"
  shutdown_command = "shutdown -P now"
  vmx_data = {
    "displayName" = "sentenai-fdb-300",
    "memsize" = "8192",
    "numvcpus" = "4",
  }

  disk_type_id = "0"
  disk_adapter_type = "nvme"
  disk_additional_size = [
    150000,
    150000
  ]
}

build {
  sources = ["sources.vmware-vmx.sentenai-fdb-300"]
}

Operating system and Environment details

Linux zin 5.15.0-58-generic hashicorp/packer#64-Ubuntu SMP Thu Jan 5 11:43:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

PRETTY_NAME="Ubuntu 22.04.1 LTS"
NAME="Ubuntu"
VERSION_ID="22.04"
VERSION="22.04.1 LTS (Jammy Jellyfish)"
VERSION_CODENAME=jammy
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=jammy

Log Fragments and crash.log files

2023/02/09 12:47:38 packer-plugin-vmware_v1.0.7_x5.0_linux_amd64 plugin: 2023/02/09 12:47:38 Executing: /usr/bin/vmware-vdiskmanager -c -s 150000M -a nvme -t 0 output-sentenai-fdb-300/disk-1.vmdk
2023/02/09 12:47:38 packer-plugin-vmware_v1.0.7_x5.0_linux_amd64 plugin: 2023/02/09 12:47:38 stdout: Creating disk 'output-sentenai-fdb-300/disk-1.vmdk'
2023/02/09 12:47:38 packer-plugin-vmware_v1.0.7_x5.0_linux_amd64 plugin: Virtual disk creation successful.

VMX file

sentenai-fdb-300.vmx

[dentarg]

Do we need #95 but for vmware-vmx?

[dentarg]

It is possible to workaround by modifying the .vmx file by hand, like this: https://github.com/twingly/boxes/pull/41/files#diff-4fe8a1eab654c9187ffc929de002763e4733d26df46a5ed11579bedca698d2f6R110-R112