leadership: pause and unpause workers consistently #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2020 10:48
This fixes a bug where leadership establishment pauses 3/4 of workers but stepping down unpause only 1/2!
shoenig
approved these changes
Jun 3, 2020
schmichael
approved these changes
Jun 4, 2020
notnoop
pushed a commit
that referenced
this pull request
Jun 4, 2020
leadership: pause and unpause workers consistently
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where leadership establishment pauses 3/4 of workers
but stepping down unpause only 1/2!
The test fails initially in https://circleci.com/gh/hashicorp/nomad/73154 but passes with the fix in latest revision.