Backport of node endpoints: do not create evals for sysbatch jobs into release/1.8.x #23876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/b-sysbatch-node-update-evals/lately-pro-possum
branch
from
a7d5975
to
570bea8
Compare
pkazmierczak
approved these changes
Aug 27, 2024
pkazmierczak
deleted the
backport/b-sysbatch-node-update-evals/lately-pro-possum
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23858 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
The below text is copied from the body of the original PR.
node-updatetriggers should never trigger sysbatch allocations, these should only ever be create byperiodic-joborjob-register.An example scenario is: an allocation spawned by a sysbatch periodic job is running on a node, the allocation gets stopped, GC runs, the node becomes ineligible and eligible again, all within the parent sysbatch job period window. If this happens,
node-updatewill trigger the system scheduler and prematurely start an allocation. This is not a desired behavior, and in fact a bug.Ref: https://hashicorp.atlassian.net/browse/NET-9323
Overview of commits