Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui, bug] UI fails to load job when there is an "@" in job name #13012

Conversation

philrenaud
Copy link
Contributor

Resolves a bug where we were mis-identifying the namespace of jobs with the "@" character in their names.

Now, we explicitly link to @default for any namespace-less links to jobs, and specifically look for the last "@" in a job name to determine namespace.

Resolves #12986

Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

ui/app/routes/jobs/job.js Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 13, 2022

Ember Asset Size action

As of 8ee9fde

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +159 B +72 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented May 13, 2022

Ember Test Audit comparison

main 8ee9fde change
passes 1287 1287 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud changed the title 12986 UI fails to load job when there is in job name in nomad 130 12986 UI fails to load job when there is an "@" in job name in nomad 130 May 13, 2022
@philrenaud philrenaud marked this pull request as ready for review May 13, 2022 19:25
@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 1efdb97:

  • Acceptance | exec: running the command opens the socket for reading/writing and detects it closing

@philrenaud philrenaud merged commit 19e2e5c into main May 13, 2022
@philrenaud philrenaud deleted the 12986-ui-fails-to-load-job-when-there-is-in-job-name-in-nomad-130 branch May 13, 2022 21:01
@philrenaud philrenaud changed the title 12986 UI fails to load job when there is an "@" in job name in nomad 130 [ui, bug] UI fails to load job when there is an "@" in job name May 16, 2022
@lgfa29 lgfa29 added the backport/1.3.x backport to 1.3.x release line label Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI fails to load job when there is @ in job name in nomad 1.3.0
4 participants