Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist shared allocated ports for inplace update #9830

Merged
merged 3 commits into from
Jan 15, 2021

Conversation

drewbailey
Copy link
Contributor

Ports were not copied over when performing inplace updates in the
generic scheduler

Fixes #9808

Ports were not copied over when performing inplace updates in the
generic scheduler
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui January 15, 2021 16:07 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad-storybook-and-ui January 15, 2021 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad January 15, 2021 16:09 Inactive
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drewbailey drewbailey merged commit 182aa4a into master Jan 15, 2021
@drewbailey drewbailey deleted the b/persist-shared-allocated-ports branch January 15, 2021 17:45
notnoop pushed a commit that referenced this pull request Jan 20, 2021
* Persist shared allocated ports for inplace update

Ports were not copied over when performing inplace updates in the
generic scheduler

* changelog

* drop spew
backspace pushed a commit that referenced this pull request Jan 22, 2021
* Persist shared allocated ports for inplace update

Ports were not copied over when performing inplace updates in the
generic scheduler

* changelog

* drop spew
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port label not found on service check update
3 participants