build: upgrade from Go 1.15.5 -> 1.15.6 #9686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmichael
force-pushed
the
golang1.15.6
branch
from
beb0e0b to
502bb95
Compare
vercel
bot
temporarily deployed
to
Preview – nomad-storybook-and-ui
schmichael
commented
Dec 18, 2020
| @@ -9,16 +9,19 @@ fi | |||
|
|
|||
| golang_version="$1" | |||
|
|
|||
| current_version=$(grep -o -e 'golang:[.0-9]*' .circleci/config.yml | head -n1 | cut -d: -f2) | |||
| current_version=$(grep -o -E -e '/golang:[.0-9]+' .circleci/config.yml | head -n1 | cut -d: -f2) | |||
There was a problem hiding this comment.
Old regex matched the install-golang: lines in config.yml.
I think only the / prefix or the -E and + are required, not both. Let me know if I should simpify it.
notnoop
approved these changes
Jan 4, 2021
Also updated scripts/update_golang_version.sh to handle new CircleCI file layout.
schmichael
force-pushed
the
golang1.15.6
branch
from
502bb95 to
240697b
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated scripts/update_golang_version.sh to handle new CircleCI
file layout.