Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set EnvVar variables in hcl2 parsing #9623

Merged
merged 2 commits into from
Dec 11, 2020
Merged

set EnvVar variables in hcl2 parsing #9623

merged 2 commits into from
Dec 11, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Dec 11, 2020

Another 🤦 case of missing to wire parameters in :( , just the environment variables this time.

Fixes #9622 .

@notnoop notnoop requested a review from shoenig December 11, 2020 18:45
@notnoop notnoop self-assigned this Dec 11, 2020
@notnoop notnoop changed the title pass envvar set EnvVar variables in hcl2 parsing Dec 11, 2020
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notnoop notnoop merged commit 3a8475e into master Dec 11, 2020
@notnoop notnoop deleted the b-hcl2-envvar branch December 11, 2020 18:59
schmichael pushed a commit that referenced this pull request Dec 16, 2020
set EnvVar variables in hcl2 parsing
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HCL2 variables not parsed from environment
2 participants