CSI: fix struct copying errors #9239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2020
tgross
force-pushed
the
b-csi-volume-copy-bugs
branch
from
c440d9f to
852971a
Compare
tgross
force-pushed
the
b-csi-volume-copy-bugs
branch
from
852971a to
849754c
Compare
tgross
force-pushed
the
b-csi-volume-copy-bugs
branch
from
350e51c to
acbdc57
Compare
tgross
force-pushed
the
b-csi-volume-copy-bugs
branch
from
acbdc57 to
8915dd0
Compare
tgross
force-pushed
the
b-csi-volume-copy-bugs
branch
from
8915dd0 to
4de0f79
Compare
notnoop
approved these changes
Nov 18, 2020
| // denormalize. | ||
| for allocID := range v.ReadAllocs { | ||
| v.ReadAllocs[allocID] = nil | ||
| } |
There was a problem hiding this comment.
Double checking assumptions: v.ReadAllocs contain non-nil pointers so we must set them to nil here?
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8949 #9230
The
CSIVolumestruct "denormalizes" allocations when it's first queried from the state store. TheCSIVolumeByIDmethod on the state store copies the volume before denormalizing so that we don't end up with unexpected changes. The copying has some subtle bugs that meant thatAllocations(as well asTopologiesandMountOptions) were not getting copied when expected.Also, ensure we never write allocations attached to volumes to the state store during claims.