Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Driver starting is included in restart policy. #859

Merged
merged 2 commits into from
Feb 29, 2016

Conversation

dadgar
Copy link
Contributor

@dadgar dadgar commented Feb 29, 2016

This PR:

  • Refactors the task_runner run() method.
  • Updates the restart tracker to take in both exit codes and start errors
  • Makes Docker Pull a recoverable error so that it may be retried.
  • Improves the output of nomad alloc-status

// Set force start because we are restarting the task.
forceStart = true
// Clear the handle so a new driver will be created.
r.handle = nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we acquire the handleLock here?

dadgar added a commit that referenced this pull request Feb 29, 2016
client: Driver starting is included in restart policy.
@dadgar dadgar merged commit 7007409 into master Feb 29, 2016
@dadgar dadgar deleted the f-driver-start-restarts branch February 29, 2016 19:05
@dgshep
Copy link

dgshep commented Mar 17, 2016

Does this fix #806?

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants