-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Scaling observability #8551
Conversation
Ember Asset Size actionAs of 75aa9ce Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn’t manage to gain access to the test autoscaling cluster, so I only tried this out in Mirage, but it looks good to me! I left some minor comments for possible improvements but nothing blocking. 🥳
@@ -1,5 +1,5 @@ | |||
{{#if this.isOpen}} | |||
<div data-test-accordion-body class="accordion-body"> | |||
<div data-test-accordion-body class="accordion-body {{if this.fullBleed "is-full-bleed"}}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this dedent is unintentional?
<span data-test-time title="{{format-ts a.item.time}}">{{format-month-ts a.item.time}}</span> | ||
</span> | ||
</div> | ||
<div class="column is-2"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it’s overkill but I hovered over this just to see, a tooltip/title like “Scaled up/down to X” could be nice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that could be nice. The autoscaler folks are also looking into improving the messages they emit, so that should help too.
import { tagName } from '@ember-decorators/component'; | ||
|
||
@tagName('') | ||
export default class ScaleEventsAccordion extends Component {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file can be deleted entirely thanks to Octane 🤓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OH YEAH! So if you don't make a component js file, it defaults to a glimmer component?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya exactly 🤠
6c6eb05
to
a45f316
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This adds recent scaling events to the Task Group Detail page.
Scaling events will typically be generated by the nomad autoscaler, but they can also be generated by the UI and any api calls to
POST /v1/:job/scale
.