Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Filter out new records from the job list page #8412

Merged
merged 2 commits into from
Jul 10, 2020

Conversation

DingoEatingFuzz
Copy link
Contributor

When a prefix is set and the run job button is clicked, the new job would cause an error because it has no name yet.

Closes #7032

@DingoEatingFuzz DingoEatingFuzz added this to the 0.12.1 milestone Jul 10, 2020
@github-actions
Copy link

github-actions bot commented Jul 10, 2020

Ember Asset Size action

As of 8c3d514

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +38 B +12 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jul 10, 2020

Ember Test Audit comparison

master 8c3d514 change
passes 1288 1289 +1
failures 0 0 0
flaky 0 0 0
duration 6m 00s 762ms 6m 21s 652ms +20s 890ms

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used to think it was exciting that new records were automatically part of collections and now I’m usually annoyed that I always have to filter them out 😆 nice simple intervention and accompanying test though 😀

When a prefix is set and the run job button is clicked,
the new job causes an error because it has no name yet.
@DingoEatingFuzz DingoEatingFuzz force-pushed the b-ui/prefix-run-button branch from 287e8ac to 8c3d514 Compare July 10, 2020 22:31
@DingoEatingFuzz DingoEatingFuzz merged commit dc6aa33 into master Jul 10, 2020
@DingoEatingFuzz DingoEatingFuzz deleted the b-ui/prefix-run-button branch July 10, 2020 22:41
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Jobs list prefix filter: Cannot read property 'startsWith' of undefined
2 participants