UI: CSI Availability Gauges #7911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregone
reviewed
May 13, 2020
ui/app/components/gauge-chart.js
Outdated
| this.renderChart(); | ||
| }, | ||
|
|
||
| mountD3Elements() {}, |
There was a problem hiding this comment.
Lol, whoops. You caught me copy/pasting. Will delete 👍
gregone
reviewed
May 13, 2020
backspace
approved these changes
May 13, 2020
ui/app/components/gutter-menu.js
Outdated
| // a storage-related page, context should be reset to volumes. | ||
| const destination = this.router.currentRouteName.startsWith('csi.') ? 'csi.volumes' : 'jobs'; | ||
|
|
||
| this.router.transitionTo(destination, { |
There was a problem hiding this comment.
This was already merged, right?
There was a problem hiding this comment.
Yes. I must have missed a spot when doing git surgery.
| label: 'Gauge', | ||
| }); | ||
|
|
||
| test('presents as an svg, a formatted percentage, and an svg', async function(assert) { |
There was a problem hiding this comment.
Is this meant to be “and a label” maybe?
DingoEatingFuzz
force-pushed
the
f-ui/csi-availability-gauge
branch
from
f654516 to
0a258b1
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They look like this and are used to measure how many instances of CSI node and controller plugins are in a healthy state:
Includes: