Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nomad monitor command to lookup server UUID #7015

Merged
merged 2 commits into from
Jan 29, 2020

Conversation

drewbailey
Copy link
Contributor

@drewbailey drewbailey commented Jan 29, 2020

Allows addressing servers with nomad monitor using the servers name or ID.

Also unifies logic for addressing servers for client_agent_endpoint
commands and makes addressing logic region aware.

fixes #6847

nomad/client_agent_endpoint.go Outdated Show resolved Hide resolved
nomad/rpc.go Show resolved Hide resolved
nomad/rpc.go Outdated Show resolved Hide resolved
nomad/rpc.go Outdated Show resolved Hide resolved
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget changelog and docs changes (if necessary)

@schmichael
Copy link
Member

Oops and might want to checkout those test failures. Some seem related.

Allows addressing servers with nomad monitor using the servers name or
ID.

Also unifies logic for addressing servers for client_agent_endpoint
commands and makes addressing logic region aware.

rpc getServer test
@drewbailey drewbailey merged commit 07df966 into master Jan 29, 2020
@drewbailey drewbailey deleted the b-allow-monitor-by-server-id branch January 29, 2020 19:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow server uuids for nomad monitor -server-id
2 participants