Allow users to configure arbitrary headers in config #699
Conversation
diptanu
force-pushed
the
f-api-response-headers
branch
from
c3e7dec to
ab0ca58
Compare
| @@ -18,6 +18,7 @@ IMPROVEMENTS: | |||
| * drivers: Interpret Nomad variables in environment variables/args [GH-653] | |||
| * core: Populate job status [GH-663] | |||
| * core/cli: Print short identifiers and UX cleanup [GH-675, GH-693, GH-692] | |||
| * api: Allow users to set arbitrary headers via agent config [GH-699] | |||
There was a problem hiding this comment.
Don't we normally handle the CHANGELOG outside of the PR itself? I think this should also be core/api as we have used before.
There was a problem hiding this comment.
Yeah makes sense regarding renaming it to core/api. These days we are doing the CHANGELOG with the PRs so that we don't forget about them. Is there any downside to doing this?
There was a problem hiding this comment.
Nope just general practice so far is all. NBD!
|
@diptanu code LGTM! Just one comment about the changelog. |
Allow users to configure arbitrary headers in config
|
Thanks! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #697