Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort config files as documented. #588

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Sort config files as documented. #588

merged 1 commit into from
Dec 15, 2015

Conversation

ChrisHines
Copy link
Contributor

Fixes #587.

@diptanu
Copy link
Contributor

diptanu commented Dec 15, 2015

LGTM. This is breaking on my local environment too. I wonder why our build was not broken in the CI. Further this test doesn't need to be run as a root as well.

@ChrisHines
Copy link
Contributor Author

The tests worked for me on Ubuntu with ext4 and on Windows. With only two config files in the test directory it may be a 50% shot that directory order is not alphabetical, or it could be very OS or filesystem dependent. Googling for "linux directory order" produces some interesting reading.

@diptanu
Copy link
Contributor

diptanu commented Dec 15, 2015

@ChrisHines Thanks for the explanation, makes sense.

diptanu added a commit that referenced this pull request Dec 15, 2015
Sort config files as documented.
@diptanu diptanu merged commit a57cc6f into hashicorp:master Dec 15, 2015
@ChrisHines ChrisHines deleted the config-sort branch December 15, 2015 07:20
@github-actions
Copy link

github-actions bot commented May 1, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants